Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Prevent valid entries from disappearing from rope table #3740

Closed
nirvdrum opened this issue Mar 17, 2016 · 1 comment
Closed

[Truffle] Prevent valid entries from disappearing from rope table #3740

nirvdrum opened this issue Mar 17, 2016 · 1 comment
Milestone

Comments

@nirvdrum
Copy link
Contributor

RopeTable uses its own internal key class in order to avoid constructing a rope if it's not necessary, but using several of the key fields of a rope. Since the key is never referenced outside of the lookup table itself and the lookup table is a WeakHashMap, we risk evicting values that are otherwise valid. In this case, a second rope may be created that is logically equivalent to an existing rope that was looked up from the table. There should be no functional breakage by this, but we cannot guarantee reference equality, which may cause fast paths to be skipped.

@nirvdrum nirvdrum added this to the truffle-dev milestone Mar 17, 2016
@nirvdrum
Copy link
Contributor Author

Note I've since changed the issue a bit with commit 91ec95f. Now we never expunge results. We still need to fix this, but entries won't just disappear on us.

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants