Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubbling out RaiseExceptions have different output text than MRI #3756

Closed
enebo opened this issue Mar 24, 2016 · 1 comment
Closed

bubbling out RaiseExceptions have different output text than MRI #3756

enebo opened this issue Mar 24, 2016 · 1 comment

Comments

@enebo
Copy link
Member

enebo commented Mar 24, 2016

Environment

JRuby 9.0.5.0

Expected Behavior

Exception type is after the message in parenthesis.

Actual Behavior

We print Exception type before message and delimit with a colon.

This is not a huge deal as people should not be post-processing output from a blowing up Ruby program but MRI test suite has a fairly detailed expectation in some tests in test_rubyoptions.rb.
It is simple enough to match them at least.

@enebo
Copy link
Member Author

enebo commented Mar 24, 2016

Ok so we can fix our output to match MRI's but we have an MRI output mode. I was in favor of just making this first line agree with MRI so some MRI tests would pass without passing in an env var, but @headius points out other MRI tests will break because our actual backtrace contents are also different. So I would only partially fix MRI not passing with the default JRuby-style backtrace output. Not worth changing...

@enebo enebo closed this as completed Mar 24, 2016
headius added a commit that referenced this issue Mar 24, 2016
Several tests examine error output, which does not match using our
normal backtrace style. See #3756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant