thread-context refactor backtrace retrieval #3722
Closed
+29
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... not really "creating" the backtrace - simply returning raw tracked backtrace elements
…val for given level
|
Are the "final" variable changes something your editor/IDE is doing? I don't mind it for new code but making changes like that in otherwise-unmodified code really messes up the diff. Otherwise, this seems like a fine change and you should go ahead with it. |
|
@headius yep, thanks - will try to tidy up the commit to avoid unrelated changes. |
|
cleaned up: f060c79 and pushed to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
historically there's
createBacktrace2(int level, boolean nativeException)... whose parameters are no longer used, proposing a
getBacktrace()insteadgetter name chosen since thread-context manages a backtrace state - does not need to create/generate one.
alternatively
getBacktrace(int level)is added although we do not use the API.