New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler config deps #1585
Compiler config deps #1585
Conversation
I think |
Ugh. Ok. |
I think doit will try to execute each string as a shell command, and use its return value to determine whether the task changed or not. That's not what you want, I think? |
Indeed. |
Just out of curiosity, is add_dependency_uptodate used anywhere so I can see how it's done there? |
If you want to update if the list of strings changed (maybe you want to sort the list to avoid list reordering triggering rebuilds), use |
I found an example in one of my (not yet published) plugins:
|
ok, pushing now. |
The ID you say "unique"... that means unique in the context of that specific task, right? Not unique across all the tasks? |
It should be unique over all posts and tasks, because it could happen that different tasks add something to the uptodate dependency of a post, and many posts are on one index/list/... page, and all those uptodate dependencies are put into the uptodate dependency on the generated index/list/... I'd use a combination of the task/plugin/... name and the post's source path. |
Ugh again then. This method is completely unusable based on the documentation there. It's a strange feeling to have no idea how this works. I think we should remove the marketing stuff about how nikola's codebase is easy to understand. |
Last question: it has to be unique across the whole build and stable from one build to another? |
Yes. (Of course, it should be stable iff the options it contains don't change.) |
This should fix Issue #1523