-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiled .rb does not handle rest kwargs right #3734
Comments
I can still fix this for 9.1. Must be using incorrect logic for kwargs in the compiler. |
Very strange. I did not realize this was a jrubyc test at first, and tested normal JIT compilation...which works fine. Current jrubyc in 9k does not actually compile code all the way to JVM bytecode, so this is likely a problem with how we're encoding IR into the binary string we store in jrubyc's .class output. @enebo I'll be poking at IR serialization, but maybe you have some ideas here. |
IR for running normally at command line (works properly):
And running from jrubyc-compiled output (which does not work properly):
I'm not sure I see a difference yet. |
More confirmation that something is getting lost in IR persistence:
|
The blah.rb in question that I'm using to test: def generic(*args, **kwargs, &block)
[ args, kwargs, block ]
end
p generic('0', 111, arg: 1) { 'block' } |
Have been adding some "edge" case specs for jrubyc as there's been a lot of regression around loading compiled .class files.
Issue
Stumbled upon:
this is part of the spec:jrubyc suite
Expected Behavior
bin/jruby -S rake spec:jrubyc
currently pending due :The text was updated successfully, but these errors were encountered: