Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmus: add gcc build dep for darwin #14204

Closed
wants to merge 1 commit into from
Closed

cmus: add gcc build dep for darwin #14204

wants to merge 1 commit into from

Conversation

benmont
Copy link
Contributor

@benmont benmont commented Mar 25, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

cc @oxij

Please note, that points are not mandatory, but rather desired.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @oxij, @peti and @vbgl to be potential reviewers

@pSub pSub added the 6.topic: darwin Running or building packages on Darwin label Mar 26, 2016
@fpletz
Copy link
Member

fpletz commented Mar 30, 2016

@benmont Could we maybe only add the gcc dependency if we're on darwin? For instance, if we ever decide to make clang the default compiler this might break the build. Or does cmus doesn't work with clang, which iirc is the default on darwin?

@joachifm
Copy link
Contributor

joachifm commented Apr 1, 2016

Looks to me like cmus actively supports building with clang. Without explication, I move to close this.

@benmont
Copy link
Contributor Author

benmont commented Apr 1, 2016

I haven't had a chance to look into this since I submitted the PR. When I
attempted to build on darwin, it failed on a gcc check in the configuration
script. If it can build with clang, something else needs to change for that
to work on darwin.

Michael

On Fri, Apr 1, 2016 at 5:30 PM, joachifm notifications@github.com wrote:

Looks to me like cmus actively supports building with clang. Without
explication, I move to close this.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#14204 (comment)

@oxij
Copy link
Member

oxij commented Apr 22, 2016 via email

@joachifm
Copy link
Contributor

cc @LnL7 any thoughts on this re darwin?

@LnL7
Copy link
Member

LnL7 commented Jan 24, 2017

I'm seeing missing frameworks when building it on darwin, I doubt this is relevant.

@LnL7 LnL7 mentioned this pull request Jan 24, 2017
Merged
6 tasks
@LnL7
Copy link
Member

LnL7 commented Jan 24, 2017

Closing in favour of #22116

@LnL7 LnL7 closed this Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@benmont @mention-bot @fpletz @joachifm @oxij @LnL7 @pSub