Empty info #177
Merged
Empty info #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the $piddle->info command or 'help vars' or '? vars' from the perldl shell, both null piddles and empty piddles were printed as 'PDL->null'. But empties and nulls are not the same: empties have a type, and a dim list (at least 1 dim is size 0). This change allows empties to show up in the variable listing as such, and I added some tests.
This was already the case for which and which_both, so now whichND returns indx piddles as well. Added 5 tests to t/primitive.t to deal with (most of?) the edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch clarifies the status of empty piddles by PDL::info (and thus 'help vars' in the shell). Previously empty piddles were listed as PDL->null, which is incorrect. Now they are listed as their correct type and dimensions (at least one of which is 0). Since which & whichND are used to generate various kinds of empties, I also made sure that whichND returns piddles of the correct type (indx).