-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a63f1cfd8c14
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 409c7e654c3b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 14 files changed
- 3 contributors
Commits on Mar 23, 2016
-
[Truffle] Backed out concat rope depth limiting specializations.
These specializations made compiled code much slower and had meager memory savings. The larger idea is sound, but we need to rethink the approach.
Configuration menu - View commit details
-
Copy full SHA for 079efd4 - Browse repository at this point
Copy the full SHA 079efd4View commit details -
Make parser stop updating coverage data for any eval-related parses.
This feature is only for load/require'd files. A second fix will be required to actually fix #1196 since we have a global event registered but we can at least make sure coverage array is the proper size now.
Configuration menu - View commit details
-
Copy full SHA for 89f4c06 - Browse repository at this point
Copy the full SHA 89f4c06View commit details -
Make RootNode of AST know whether it requires coverage or not.
This is infrastructure work and not a full fix for #1196. I kept this separate in case we decide to fix 1.7.x as the rest of the fixes will be in IR (which 1.7 lacks).
Configuration menu - View commit details
-
Copy full SHA for 39d35c0 - Browse repository at this point
Copy the full SHA 39d35c0View commit details -
Form-fitting a bit. MRI will not wipe out the coverage arrays on a re…
…set. What they do instead is if visited then they leave the entry but wipe out the array. If they have nothing marked as visited they leave that entry unchanged.
Configuration menu - View commit details
-
Copy full SHA for d136537 - Browse repository at this point
Copy the full SHA d136537View commit details -
Fixes #1196 Coverage reports wrong number of lines...and then some.
This also fixes remaining tagged out MRI test_coverage.rb issues. Changes: - Event hook removes lots of extra sanity checks which almost entirely was fall out from evals being treated as needing coverage. So, for example, random line number oddities no longer exist because load/require always starts at line 0. - Removed errant printf from last commit. - Instrument COVERAGE Events where LINE events happen so long as the AST/IRScope being built requires coverage. I notice MRI does not emit both LINE + COVERAGE when COVERAGE is present so perhaps this is a future thing to change. Adding this instrumentation ended up being much ickier than an- ticipated since we: a: lazily compile methods b: transform define_method blocks to IRMethods and re-build These two "lazy" builds required adding a new IRScope field called CODE_COVERAGE. - Fixed inverted logic in ParserConfiguration from last commit. - CoverageData was missing a significant piece of behavior. If result was called and then start was reenabled any files which had already had coverage happen to them are supposed to replace their line array with an empty one {"foo.rb" => []}. This was key piece to eliminating remaining MRI tests from failing. I also ran specs from simplecov and it is green. As far as I know there are no more missing behavior from coverage. @donv has said he would add specs to ruby/spec for coverage. At this time there are no specs for coverage there at all.
Configuration menu - View commit details
-
Copy full SHA for 35c1998 - Browse repository at this point
Copy the full SHA 35c1998View commit details -
Configuration menu - View commit details
-
Copy full SHA for c02d46d - Browse repository at this point
Copy the full SHA c02d46dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e3c54b - Browse repository at this point
Copy the full SHA 5e3c54bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07041c6 - Browse repository at this point
Copy the full SHA 07041c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 409c7e6 - Browse repository at this point
Copy the full SHA 409c7e6View commit details
There are no files selected for viewing