Add hydraPlatform to all ocaml modules and ocaml versions. #13976
Conversation
|
By analyzing the blame information on this pull request, we identified @FlorentBecker, @vbgl and @jirkamarsik to be potential reviewers |
|
Why do you need this? The default value (i.e., |
|
@vbgl We need this to prevent hydra from doing extra work while providing correct platforms information. I noticed this issue while making an attempt to list all packages available in Nix, which apparently ended-up evaluating the platforms list. As requested by @globin , it would be better to have correct platforms information, and add the hydraPlatforms attribute to filter, instead of using the This patch does that, it adds the hydraPlatforms information, such that we do not build where we do not intend to build, and add the platform field, such that we do not get errors while listing all packages. |
| @@ -69,6 +69,7 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| platforms = with platforms; linux ++ darwin; | |||
| hydraPlatforms = with platforms; linux ++ darwin; | |||
There was a problem hiding this comment.
isn't hydraPlatforms = platforms by default ?
There was a problem hiding this comment.
No, I do not think so, the release script fallbacks on platforms if there is no hydraPlatforms attribute.
|
I can't stop thinking that removing the two old crusty ocaml versions would also solve the problem. |
Yes, this would work too. |
|
Fixing evaluation is fine. It is addressed by
d000bcd2706e3ee66cddc891cbdf13f5fed5169e which should have been applied
instead of #13897.
This patch does that, it adds the hydraPlatforms information, such
that we do not build where we do not intend to build
Please show which OCaml modules are built by hydra but should not be.
If there is no `recurseIntoAttrs`, Hydra does not build derivations in
embedded attribute sets.
|
nbp
force-pushed
the
ocaml-hydraplatforms
branch
from
ab06bf6
to
df37251
Compare
|
Is this still needed now that 4.02 is the default ocaml? |
|
Is this still an issue? |
I don't think so; if I'm wrong feel free to rebase, fixup merge conflicts, and re-open. |
This is a followup to #13897 (comment)
Which adds the
hydraPlatformsattribute to all ocaml modules, and to all ocaml derivations too.cc @zimbatm, @vbgl and @globin