Instantiate both the RSA private and public keys when setting parameters #82
+79
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RSA
e
(exponent) andn
(modulus) parameters are initially backed by thersa_e
andrsa_n
fields. These fields are then used to instantiate the internalprivateKey
andpublicKey
objects ingeneratePrivateKeyIfParams()
andgeneratePublicKeyIfParams()
. However, bothrsa_e
andrsa_n
are set tonull
after use. This means that once either of the private or public keys has been created, the other cannot be. Consequently, the RSA object can only be used for private or public functions, but not for both.For example:
When the above code is run using the MRI standard library, both the
public_encrypt
andprivate_encrypt
calls succeed.This pull request modifies
generatePrivateKeyIfParams()
andgeneratePublicKeyIfParams()
so that they will obtain thee
andn
parameters from eitherprivateKey
orpublicKey
ifrsa_e
andrsa_n
have already been consumed.