Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Add copy of 2.2.2 stdlib #3717

Merged
merged 8 commits into from
Mar 10, 2016
Merged

[Truffle] Add copy of 2.2.2 stdlib #3717

merged 8 commits into from
Mar 10, 2016

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Mar 8, 2016

JRuby+Truffle does not support 2.3 features yet, so it needs copy of 2.2.2 stdlib.
cc @jruby/truffle, @headius, @enebo

@pitr-ch pitr-ch added the truffle label Mar 8, 2016
@pitr-ch pitr-ch self-assigned this Mar 8, 2016
@pitr-ch pitr-ch added this to the truffle-dev milestone Mar 8, 2016
@headius
Copy link
Member

headius commented Mar 8, 2016

Ugh...we really don't want to have two copies of stdlib in the repo again if we can avoid it. Perhaps the few features you need to use the 2.3 stdlib would not be too difficult to implement?

@chrisseaton
Copy link
Contributor

Yeah we thought you may not be keen - it's a reasonable response.

Ideally we'll implement the 2.3 features quickly, but in the mean time it's not great to be working on other things and having some random failures here and there from the new stdlib.

How long could we have this in? Are you releasing imminently?

@pitr-ch
Copy link
Member Author

pitr-ch commented Mar 9, 2016

The copy was updated to contain only what's actually needed by JRuby+Truffle, it has only 3,4MB now.

@enebo
Copy link
Member

enebo commented Mar 9, 2016

I also find this undesirable but so long as the timeframe does not stretch multiple point releases and there is a plan for removing this I think we can eat the extra space in a single point release. I partially blame us for not collaborating on this version move a bit more.

@pitr-ch
Copy link
Member Author

pitr-ch commented Mar 10, 2016

Ok thanks, it helps a lot. I'll rebase and merge.

@kares
Copy link
Member

kares commented Mar 10, 2016

you guys considered how confusing such a release might get for end users - esp. ones trying out truffle?

@pitr-ch
Copy link
Member Author

pitr-ch commented Mar 10, 2016

@kares valid point, I'll move the copy to truffle directory so it's clear what is the purpose of the copy.

pitr-ch pushed a commit that referenced this pull request Mar 10, 2016
[Truffle] Add copy of 2.2.2 stdlib
@pitr-ch pitr-ch merged commit b352e8c into jruby:master Mar 10, 2016
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants