-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Add copy of 2.2.2 stdlib #3717
Conversation
Ugh...we really don't want to have two copies of stdlib in the repo again if we can avoid it. Perhaps the few features you need to use the 2.3 stdlib would not be too difficult to implement? |
Yeah we thought you may not be keen - it's a reasonable response. Ideally we'll implement the 2.3 features quickly, but in the mean time it's not great to be working on other things and having some random failures here and there from the new stdlib. How long could we have this in? Are you releasing imminently? |
The copy was updated to contain only what's actually needed by JRuby+Truffle, it has only 3,4MB now. |
I also find this undesirable but so long as the timeframe does not stretch multiple point releases and there is a plan for removing this I think we can eat the extra space in a single point release. I partially blame us for not collaborating on this version move a bit more. |
Ok thanks, it helps a lot. I'll rebase and merge. |
you guys considered how confusing such a release might get for end users - esp. ones trying out truffle? |
@kares valid point, I'll move the copy to truffle directory so it's clear what is the purpose of the copy. |
JRuby+Truffle does not support 2.3 features yet, so it needs copy of 2.2.2 stdlib.
[Truffle] Add copy of 2.2.2 stdlib
JRuby+Truffle does not support 2.3 features yet, so it needs copy of 2.2.2 stdlib.
cc @jruby/truffle, @headius, @enebo