Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic port allocation limit #4949

Merged
merged 1 commit into from Apr 1, 2014

Conversation

tjmehta
Copy link
Contributor

@tjmehta tjmehta commented Apr 1, 2014

I made findNextPort search circularly rather than ending at EndPortRange. findNextPort will continue to search for a port until it determines that all the ports are allocated and return ErrAllPortsAllocated.

@tjmehta
Copy link
Contributor Author

tjmehta commented Apr 1, 2014

fixes #4908

@crosbymichael
Copy link
Contributor

@tjmehta can you sign your commit with the proper DCO please?

Docker-DCO-1.1-Signed-off-by: Tejesh Mehta <tejesh.mehta@gmail.com> (github: tjmehta)
@tjmehta
Copy link
Contributor Author

tjmehta commented Apr 1, 2014

updated with DCO

@crosbymichael
Copy link
Contributor

@tjmehta What do you think about adding a unit test for this? I think it would be easy?

@tjmehta
Copy link
Contributor Author

tjmehta commented Apr 1, 2014

https://github.com/tjmehta/docker/blob/4908-fix_dynamic_port_allocation_limit/runtime/networkdriver/portallocator/portallocator_test.go#L99

The test is already in place. What do you think, is it sufficient?

Tejesh

On Tue, Apr 1, 2014 at 10:00 AM, Michael Crosby notifications@github.comwrote:

@tjmehta https://github.com/tjmehta What do you think about adding a
unit test for this? I think it would be easy?

Reply to this email directly or view it on GitHubhttps://github.com//pull/4949#issuecomment-39230388
.

@crosbymichael
Copy link
Contributor

LGTM

1 similar comment
@creack
Copy link
Contributor

creack commented Apr 1, 2014

LGTM

creack added a commit that referenced this pull request Apr 1, 2014
…n_limit

Fix dynamic port allocation limit
@creack creack merged commit 7462cc6 into moby:master Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants