Allow DSA private keys to be initialized from parameters #83
+167
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to initialize an instance of
OpenSSL::PKey::DSA
for use as a private key by setting the individual parameters. This is because thepriv_key=
method is missing andsetKeySpecComponent()
only handles the creation of thepublicKey
.This pull request adds a
priv_key=
method and modifiessetKeySpecComponent()
method to initializeprivateKey
in addition topublicKey
.Similarly to #82 the DSA
p
,q
andg
parameters are shared between the private and public keys. I've changedsetKeySpecComponent()
to read these parameters fromprivateKey
orpublicKey
if necessary.