Allow DSA private keys to be initialized from parameters #83
+167
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis CI build has failed due to my use of the |
- OpenSSL::PKey::DSA was missing a priv_key= method. - setKeySpecComponent() only handled the creation of the DSAPrivateKey.
philr
force-pushed
the
set_dsa_private_key_from_params
branch
from
ee332db to
d219115
Compare
|
I have amended my commit to replace the problematic |
|
thanks, esp. that you got us some new tests - much appreciated! |
kares
added a commit
that referenced
this pull request
Mar 10, 2016
Allow DSA private keys to be initialized from parameters
philr
added a commit
to philr/putty-key
that referenced
this pull request
Mar 28, 2016
DSA/DSS keys will be supported once jruby/jruby-openssl#82 is released. RSA keys will be instantiated correctly once jruby/jruby-openssl#83 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to initialize an instance of
OpenSSL::PKey::DSAfor use as a private key by setting the individual parameters. This is because thepriv_key=method is missing andsetKeySpecComponent()only handles the creation of thepublicKey.This pull request adds a
priv_key=method and modifiessetKeySpecComponent()method to initializeprivateKeyin addition topublicKey.Similarly to #82 the DSA
p,qandgparameters are shared between the private and public keys. I've changedsetKeySpecComponent()to read these parameters fromprivateKeyorpublicKeyif necessary.