[WIP] Gem with config #14096
Closed
[WIP] Gem with config #14096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
force-pushed
the
gem-with-config
branch
from
1cf4f5f
to
a829b3e
Compare
|
I don't know if this work is still in progress, but I don't feel bad closing old PRs of people with commit access |
|
(even if commit access was given after the PR in question, yes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)The goal of this PR was to move the application of the gemConfig inside of buildRubyGem so we can also benefit from those patches if buildRubyGem is used directly.
The implementation is not entirely satisfying and I'm looking for feedback if it's possible to make it any shorter.
The last commit is a different project and is WIP but I used it to test my changes.