-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue when connected to network #3744
Comments
This is the java program:
I put all needed gems and specifcations in the classpath. I observed that the described behavior does not occur on every machine. Maybe because of some network setting regarding the resolution of resources beginning with '//' |
And here is the stack
|
Yikes obviously a "//foo/bar" which does not exist will take time on windows but since this is originally a url this is clearly stripping the url bits off wrong. |
Hmm I should say root cause of this is not that windows takes a long time to resolve non-existent UNC paths (which it seems to take forever in explorer too) but that we are not properly processing our URLs to paths properly internally. |
|
…id \\network on win jruby#3744
HAHAHA @kares I was looking into this afternoon and did not see your commit. I was so confused why the result seemed to be correct :) @kisho23 could you verify that our nightly fixes this: http://ci.jruby.org/ ? |
@enebo yeah, forgot to comment - sorry. this could still use a test case (on Windows which I'm not). |
@enebo Using jruby-complete-9.0.5.0.jar Using jruby-complete-9.1.0.0-SNAPSHOT.jar |
@kisho23 also do you happen to also test this against jruby 1.7.x? I think that is current JRuby still supported by asciidoctor isn't it? |
Hello, |
@enebo I suggest we close this as fixed for 9.1. If someone else reports it against 1.7 we can fix it there in a separate issue. |
@headius yeah until github issues allows us to maintain two milestones for one issue we should be doing that anyways. |
Environment
Expected Behavior
I just playing around with asciidoctor.
I put all gems and specifications in the classpath.
The program should start in the same time either if the network is connected or not.
Actual Behavior
If the network is connected it needs 1 minute.
If the network is not connected it need 5 seconds
After some debugging I found out that
uri:classloader://specifications/asciidoctor-1.5.4.gemspec
yields to a
new File("//specifications/asciidoctor-1.5.4.gemspec").exists()
Under Windows "//specifications" is a network drive, which can not be resolved.
I think this is the reason for my performance problem in case the laptop is connected to the network.
The text was updated successfully, but these errors were encountered: