Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO#write_nonblock causes CCE on Windows #3745

Closed
enebo opened this issue Mar 18, 2016 · 1 comment
Closed

IO#write_nonblock causes CCE on Windows #3745

enebo opened this issue Mar 18, 2016 · 1 comment
Labels
windows
Milestone
JRuby 1.7.25

Comments

@enebo
Copy link
Member

enebo commented Mar 18, 2016

Environment

JRuby 1.7.25 on windows

Expected Behavior

To not crash with a classcastexception.

Actual Behavior

Classcastexception based on wanting a ChannelStream but getting a CRLFStreamWrapper.
@enebo enebo added the windows label Mar 18, 2016
@enebo enebo added this to the JRuby 1.7.25 milestone Mar 18, 2016
@enebo
Copy link
Member Author

enebo commented Mar 18, 2016

This causes about 12 specs on spec:ruby19:fast to fail.

enebo added a commit that referenced this issue Mar 18, 2016
@enebo
Fixes #3745. IO#block_nonwrite causes CCE on Windows.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
3eb8c5f 
I made a marker interface so that both ChannelStream and CRLFStream
wrapper can have a common type so they can call writenonblock.  I added
an error check to throw and IOException if CRLFStreamWrapper is wrapping
from stream type but I suspect it is an impossible path by this point in
our code.  Zero 1.7 risk fix since this was just dumping stack before.
@enebo enebo closed this as completed Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
JRuby 1.7.25
Development

No branches or pull requests
1 participant
@enebo