Book tutorial #30
Merged
Book tutorial #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| But sometimes, you don't want to do the same thing you have been doing. Sometimes you | ||
| want to make a one-off, a special thing, and Nikola should not get in the way | ||
| of you doing that, either, and should let you get your hands as dirty as you want. |
|
@Kwpolska done, care to take a final look for wording and that kind of thing? |
| .chapter { | ||
| width: 100%; | ||
| padding: 10px; | ||
| -webkit-column-gap: 40px; |
There was a problem hiding this comment.
Shouldn’t we add prefixless column-* properties for other browsers? How does this work in Firefox?
There was a problem hiding this comment.
I don't know! Let's see...
There was a problem hiding this comment.
It works ... HORRIBLY! Ok, I'll add the other variants.
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
| And you know what happened? I fixed the bugs, and I will implement the feature request! And if you try to do | ||
| cool crazy stuff with Nikola, you will find bugs, and will ask for features, and there is a pretty good | ||
| chance we will fix them, or find workarounds. After all we have already done it at least | ||
| `1179 times. <https://github.com/getnikola/nikola/issues?q=is%3Aissue+is%3Aclosed>`__ |
There was a problem hiding this comment.
Update the number (1,188), or make it 2,011 and include pull requests (which might make some sense)
There was a problem hiding this comment.
Well, that number is never going to be fixed, and PRs is cheating, because we often have PRs for a bug report :-)
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until I rewrite it. On reading it after sleeping on it, I don't like some things in it. I will move a bunch of the descriptions to comments in the templates, and trim the listings to show only the most relevant parts. It's a minor rewrite, and I should be able to do it tonight, or tomorrow night.
Do not merge until typogrify works properly with the final version of the template using nikola from master.Things to fix: