stage-1-init: add support for the ability of specify a name of squashfs image #9722
Conversation
akaWolf
force-pushed
the
stage-1-init
branch
from
fe09a48
to
43c1484
Compare
|
cc @edolstra |
akaWolf
force-pushed
the
stage-1-init
branch
from
43c1484
to
9637c9c
Compare
|
@edolstra can you review that PR? |
|
This change doesn't affect existing configs (barring potential syntax errors) and so could probably be merged without @edolstra's explicit approval, esp. seeing as they have not found it necessary to comment. I suppose the only point of contention is whether the use case occurs frequently enough to warrant the increase in code size. I have no use for this myself and so hesitate to merge without ACK from someone who might care. |
| @@ -108,6 +108,10 @@ for o in $(cat /proc/cmdline); do | |||
| boot.panic_on_fail|stage1panic=1) | |||
| panicOnFail=1 | |||
| ;; | |||
| boot.iso=*) | |||
There was a problem hiding this comment.
shouldn't this be called boot.image instead ?
There was a problem hiding this comment.
both variants are acceptable for me.
akaWolf
changed the title
|
@akaWolf are you still interested in getting this integrated? |
|
@joachifm why not? yep, I'm interested. |
|
I propose to close this. It is inactive for almost two years now. |
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/easy-to-use-nixos-image-generators/1887/2 |
It's very useful to have such ability, since sometimes exists a need to create bootable USB flash drive with multiple distributives and their versions. Currently with NixOS it's only possible to create one more partition with squashfs image. After that change you can specify the name of squashfs image (like
boot.iso=nixos32/rootfs.squashfsin the boot kernel options of bootloader config), and the need in creation additional partition will dissapear.