HTML escape in more places #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,8 +129,3 @@ def template_deps(self, template_name): | |||
| deps += self.template_deps(fname) | |||
| self.cache[template_name] = tuple(deps) | |||
| return list(self.cache[template_name]) | |||
|
|
|||
|
|
|||
| def striphtml(text): | |||
There was a problem hiding this comment.
Leave this in place. Even if we don’t use it by default. It can be useful in some contexts and we don’t know exactly what every theme author will want to do. Also, removing it will break all existing themes. Yikes.
|
Nice that we consistently use |
msnoigrs
force-pushed
the
htmlescape
branch
from
6c1ebe1
to
d992165
Compare
|
Thank you for checking. |
msnoigrs
force-pushed
the
htmlescape
branch
from
d992165
to
b13cf71
Compare
|
I think we can merge this, any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.