Use mirroring in NixOS not only for fetchurl. #9750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is just an initial mockup to discuss how the caching could be done. It is by no way functional or even correct syntax.
| url = head urls; | ||
| hash = outputHash; | ||
| type = outputHashAlgo; | ||
| }; |
There was a problem hiding this comment.
I don't think this is necessary, since this information is already available via other attributes (outputHash, urls, etc.). To distinguish fetchurl calls from other fixed-output derivations, it should be enough to have some constant (pass-through) attribute (like passthru.isFetchedURL).
Also, doesn't the use of an attribute set make derivation fail?
There was a problem hiding this comment.
I just wanted to collect all data that find-tarballs.nix should pass on to copy-tarballs.pl. I haven't checked whether derivation fails, thanks. Maybe I should just generate a list of attribute names?
|
Is still being worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is just an initial mockup to discuss how the caching could
be done. It is by no way functional or even correct syntax.