Can you actually make this conditional on darwin and leave it alone (i.e., still at 3.7) on that platform? I'm trying to upgrade to 3.8 right now but there are issues we've been encountering with c++ compatibility and so on.

@copumpkin done

Thanks! I assume you've built whatever depends on it on Linux? I vaguely remember mesa and things downstream from it using llvm.

The issues with LLVM have mostly been around certain changes in libc++ that happened in 3.8, and made several packages stop compiling with it. Those issues are obviously exacerbated by Darwin using LLVM to build everything, but I imagine you might find similar issues on whichever packages build with it on Linux too.

mesa doesn't seem to depend on llvm—Nix took one from the cache.

*** Downloading ‘https://cache.nixos.org/nar/1y90k9rq1mjxd6b594gshzxnizgvmq26zjdfjkxvfc53vixw63g1.nar.xz’ to ‘/nix/store/8rkvqz2x0hr23313qk2wi1ap7nffzj1k-mesa-13.0.1’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1160  100  1160    0     0    780      0  0:00:01  0:00:01 --:--:--   783

/nix/store/8rkvqz2x0hr23313qk2wi1ap7nffzj1k-mesa-13.0.1

Hmm, I must be misremembering. Either way, nox-review should be able to check stuff for you 😄

Running it now.

btw, it always takes long on ==> We're in a git repo, trying to fetch it moment. Is that ok?

Yay for nox-review! No idea what's wrong, but at least it found the problem before it bit us 😄

@copumpkin what are the issues with 3.8 on darwin?

@shlevy http://hydra.nixos.org/eval/1304050?compare=staging is somewhat informative for figuring that out, although I wish we could only look for red crosses

@shlevy there were some bdb incompatibilities that @LnL7 fixed here (and in similar patches for other versions): https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/db/clang-5.3.patch

I also discovered yesterday that removing the --enable-dbm flag will also fix one of the issues, that probably better then patching it.

@LnL7 don't we want dbm-like stuff though?

It's some sort of legacy interface apparently, so hopefully not. If something needs it I would assume that the current patch also breaks it.

Could someone help me find clang-wrapper-wrapper? I've build all of llvmPackages fine.

mesa doesn't seem to depend on llvm—Nix took one from the cache.

Mesa certainly depends on LLVM, but we have already been using 3.9 in mesa for a long time:

llvmPackagesSelf.llvm won't build for me if switched to 3.9:

/tmp/nix-build-llvm-3.9.0.drv-0/llvm/projects/compiler-rt/lib/tsan/dd/dd_interceptors.cc:226:20: error: redefinition of 'realpath'
INTERCEPTOR(char*, realpath, const char *path, char *resolved_path) {
                   ^
/nix/store/7lmqs27llkmmzd8lczjrhq805w48zp15-glibc-2.24-dev/include/bits/stdlib.h:37:8: note: previous definition is here
__NTH (realpath (const char *__restrict __name, char *__restrict __resolved))

I switched llvmPackages at least, directly in master.

obsolete