vndr: init at 20161110-cf8678f #20318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincox
approved these changes
Nov 10, 2016
|
|
||
| buildGoPackage rec { | ||
| name = "vndr-${version}"; | ||
| version = "20161110-${stdenv.lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
I think you can use lib.substring here.
| description = "Stupid golang vendoring tool, inspired by docker vendor script"; | ||
| homepage = "https://github.com/LK4D4/vndr"; | ||
| maintainers = with stdenv.lib.maintainers; [ vdemeester ]; | ||
| licence = stdenv.lib.licenses.asl20; |
There was a problem hiding this comment.
I think you can drop the stdenv from both of these.
kevincox
requested changes
Nov 10, 2016
|
|
||
| goPackagePath = "github.com/LK4D4/vndr"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Please use fetchFromGitHub
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
/ping @kevincox |
fpletz
approved these changes
Nov 22, 2016
kevincox
approved these changes
Nov 24, 2016
|
Looks good to me, I would like to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
vndr is a simple golang vendoring tool, which is inspired by docker vendor script that I tend to use on several projects.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)Signed-off-by: Vincent Demeester vincent@sbr.pm