Moves permalink hashtag into gutter in docs #3475
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samueleaton could you update your master & rebase? your master does not include your previous contributions. |
|
@bcardiff I'm not using my master branch. Should I still do it? |
|
@samueleaton the parent of 0c1403b I might be missing something, but that is way I see at:
|
samueleaton
force-pushed
the
feat/doc-permalink-gutter
branch
from
7d5e85d to
d56b892
Compare
|
@bcardiff let me know if its not fixed. I had rebased earlier and must have removed some of my older commits 🙃 |
|
Thanks @samueleaton ! |
firejox
pushed a commit
to firejox/crystal
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the permalink hashtag into the left gutter makes the header for the method more visually distinguishable. It can be difficult when looking at a large doc to distinguish where one method ends and another begins. With the octothorp in the gutter a user can use their peripheral vision, which mean better UX.
Before
After
Before
After
