Fixed #3485: Can't make class method new private on generic class

crystal-lang · Oct 30, 2016 · 4126429 · 4126429
1 parent b351d65
commit 4126429
Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/spec/compiler/semantic/generic_class_spec.cr b/spec/compiler/semantic/generic_class_spec.cr
@@ -981,4 +981,17 @@ describe "Semantic: generic class" do
       Bar(Int32).new
       )) { generic_class "Bar", int32 }
   end
+
+  it "errors if invoking new on private new in generic type (#3485)" do
+    assert_error %(
+      class Foo(T)
+        private def self.new
+          super
+        end
+      end
+
+      Foo(String).new
+      ),
+      "private method 'new' called"
+  end
 end
diff --git a/src/compiler/crystal/syntax/ast.cr b/src/compiler/crystal/syntax/ast.cr
@@ -935,6 +935,7 @@ module Crystal
       a_def.uses_block_arg = uses_block_arg?
       a_def.assigns_special_var = assigns_special_var?
       a_def.name_column_number = name_column_number
+      a_def.visibility = visibility
       a_def
     end