Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] munin: add version 2.999.3 and reworked service #20006

Closed
wants to merge 1 commit into from
Closed

[WIP] munin: add version 2.999.3 and reworked service #20006

wants to merge 1 commit into from

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Oct 30, 2016

Motivation for this change

Munin v3 has nice web interface, so let's package it ahead of it's official release.

I've developed and tested this against 16.03 and 16.09 branches.

I've chosen to create separate package and module, because:

  • I didn't like the plugin patching mechanism (it's nice that plugins can be standalone, but not very useful in presence of munin-run)
  • new munin supports more command-line options, which I'd like to use
  • new munin-httpd service would be inapplicable to old munin (but old munin-node should be compatible with new munin)
  • self-monitored munin can be started with only services.munin.enable = true;

TODOs:

  • add doc about basic munin-ng setup
  • add example of nginx caching dynamically generated graphs
  • find out if there are better alternatives to managing PERL5LIB other than via hack-like makeFullPerlPath
  • get rid of munin package double rebuild (once with plugins and once without)
  • revert nixos/modules/services/monitoring/munin.nix, I don't want to change existing expression
  • remove HTTPServerSimpleCGI, update HTTPServerSimple instead (this will require to check dependent packages)
  • find out why line sed -i 's|\\\\l||g' lib/Munin/Master/Graph.pm is necessary for graph generation (maybe we should update rrdtool?)
  • test against unstable
  • add contrib plugin suite (as requested in Munin: ability to use plugins from munin-contrib #17895)
  • add an option to runtime disable plugins
  • make default plugins error-less (currently they spam into journald)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ping @domenkozar , feedback is welcome.

@mention-bot
Copy link

@danbst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @wkennington and @edolstra to be potential reviewers.

@danbst
Copy link
Contributor Author

danbst commented Oct 31, 2016

Seems like I have to find out a solution for PERL5LIB problem first

cannot read ‘/nix/store/nri3v2g7yyiq21gf827z9f97yrcchdvi-PERL5LIB’, since path ‘/nix/store/d57r9rxx1l6mmsl73iyzk34qkjlv6yym-PERL5LIB.drv’ is not valid, at /home/travis/.nox/nixpkgs/lib/strings.nix:496:43

@betaboon
Copy link
Contributor

@danbst did you make any progress on this issue? I'm very interested in your changes.

@danbst
Copy link
Contributor Author

danbst commented May 19, 2017

Still on my TODO. I do use a variant of this, https://gist.github.com/danbst/03ea8e50de5b1b4b06dfe049f8a103c7 .

@betaboon
Copy link
Contributor

betaboon commented May 19, 2017 •
edited

@danbst as discussed on IRC i would be interested in pooling resources with you in order to get this PR done.

On the matter of renaming 'munin-cron' to 'munin':
I would prefer 'munin-master' (see [1]) as it refers to the architectural component (see [2]).

From my "user"-perspective (i just read up on munin and setup the nixos-service during two days):
The missing reference to 'munin-master' kept confusing me, because it was the "reference" given to me by the munin documentation.
IMHO providing that point of reference increases the value of munins documentation and the nixos-integration.

Just my 2cents.

[1] https://guide.munin-monitoring.org/en/latest/master/
[2] https://guide.munin-monitoring.org/en/latest/architecture/index.html#architecture-index

@danbst
Copy link
Contributor Author

danbst commented Jul 11, 2018

Abandonware, unfortunately. I don't have time to maintain this and I no longer use Munin.

@danbst danbst closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 2.status: work-in-progress 8.has: module (update) 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danbst @mention-bot @betaboon @joachifm