Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminix: init at 1.3.5 #20346

Closed
wants to merge 5 commits into from
Closed

Terminix: init at 1.3.5 #20346

wants to merge 5 commits into from

Conversation

dyrnade
Copy link
Contributor

@dyrnade dyrnade commented Nov 11, 2016

Motivation for this change

Terminix package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jgeerds
Copy link
Member

jgeerds commented Nov 11, 2016

Would it be possible to compile Terminix by our own instead of using the prebuilt binary?

@jgeerds jgeerds added the 8.has: package (new) This PR adds a new package label Nov 11, 2016
@dyrnade
Copy link
Contributor Author

dyrnade commented Nov 11, 2016

@jgeerds. It needs gtkd and it doesnt exist in nix though. So, i didnt try that way.

@dyrnade
Copy link
Contributor Author

dyrnade commented Nov 12, 2016

@jgeerds I tried packaging gtk-d but i couldnt make it build (ldconfig issues). Without gtk-d, its impossible to build terminix from source.

version = "1.3.5";

src = fetchurl {
url = "https://github.com/gnunn1/terminix/releases/download/${version}/terminix.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prebuilt binary which they provide
https://github.com/gnunn1/terminix/releases/download/1.3.5/terminix.zip

This is source code itself.
https://github.com/gnunn1/terminix/archive/1.3.5.tar.gz

I cant do anything about it.

@FRidh
Copy link
Member

FRidh commented Nov 14, 2016

I tried packaging gtk-d but i couldnt make it build (ldconfig issues). Without gtk-d, its impossible to build terminix from source.

Can you open a PR with your expression.

@FRidh FRidh mentioned this pull request Nov 14, 2016
7 tasks
@joachifm joachifm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 8, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 10, 2017

this project was renamed to tilix and merged in 54b23e6

@Mic92 Mic92 closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants