Skip to content

Commit

Permalink
Item14227: fixed use of uninitialized value
Browse files Browse the repository at this point in the history
... in a rating formfield
  • Loading branch information
MichaelDaum committed Nov 22, 2016
1 parent 36af452 commit 61d5df6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion JQueryPlugin/lib/Foswiki/Form/Rating.pm
Expand Up @@ -132,7 +132,9 @@ sub getDisplayValue {
my @htmlAttrs = ();

return
"<input type='hidden' disabled autocomplete='off' name='$this->{name}' value='$value' class='jqStars {$this->{attributes}}' "
"<input type='hidden' disabled autocomplete='off' name='$this->{name}' value='"
. ( $value // '' )

This comment has been minimized.

Copy link
@vrurg

vrurg Nov 22, 2016

Member

Are we dropping support of pre-5.10 versions? I guess it must be (defined ? : ) statement here.

This comment has been minimized.

Copy link
@MichaelDaum

MichaelDaum Nov 22, 2016

Author Member

Good catch. Yes, I think we should update https://foswiki.org/System.SystemRequirements to

"At least perl 5.12 is required. Best would be 5.22 or higher."

. "' class='jqStars {$this->{attributes}}' "
. "data-num-stars='"
. $this->{size} . "' "
. $this->getDataValues() . ">";
Expand Down

0 comments on commit 61d5df6

Please sign in to comment.