rxvt_unicode: create .desktop file #20347
Closed
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tindzk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @evolarium, @abbradar and @edolstra to be potential reviewers. |
|
Is the desktop item copied by a setup hook? Otherwise, I fail to see how it is put into the output. Normally, they are copied manually. |
tindzk
force-pushed
the
urxvt-desktop
branch
from
44a62c9 to
e8c35c8
Compare
|
Thanks for the heads-up! I've updated the commit accordingly. |
|
Merged in 70c18b5, thank you! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
URxvt doesn't show up in the start menu.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)