dobi: init at 0.8 #20124
Closed
dobi: init at 0.8 #20124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdemeester, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @edolstra to be potential reviewers. |
|
You could try to pass |
|
ooh I missed that one 馃槄 Thanks @kamilchm, I'll do that \o/ |
fpletz
requested changes
Nov 10, 2016
|
@fpletz updated by adding |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
joachifm
reviewed
Mar 12, 2017
|
|
||
| buildGoPackage rec { | ||
| name = "dobi-${version}"; | ||
| version = "v0.8"; |
There was a problem hiding this comment.
Version strings must begin with a digit. In this case, the package will end up with the name "dobi-v0.8" and no version (see builtins.parseDrvName).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
dobi is a build automation tool for Docker applications that I tend to use on several projects.
I have a question though : Is there a way to specify
-ldflagswithbuildGoPackage? (didn't find it but I might have miss something).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)馃惛
Signed-off-by: Vincent Demeester vincent@sbr.pm