docker-machine-kvm: init at master/37bb4cc67 #20402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikefaille
force-pushed
the
docker-machine-kvm
branch
from
8a412d6
to
22e1ed4
Compare
Mic92
reviewed
Nov 14, 2016
|
|
||
| buildGoPackage rec { | ||
| name = "docker-machine-kvm-${version}"; | ||
| version = "20160801-${stdenv.lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
we usually prefer released versions instead of nightly builds.
To achieve it with golang just go to project directory and say:
git checkout v0.7.0
before building.
There was a problem hiding this comment.
I'll try. I had some troubles with v0.7.0. Last updates (few) fix it (I think). After tests, if I have same issues with v0.7, I'll ask maintainer to tag master.
|
@offlinehacker Cool It seems you commit this update before me ! : https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/networking/cluster/docker-machine Then, I will close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I need kvm/libvirt plugin for docker machine.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)