ocamlPackages.alcotest: 0.4.5 -> 0.7.2 #20404
Conversation
|
@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericbmerritt, @aske and @sternenseemann to be potential reviewers. |
|
|
||
| createFindlibDestdir = true; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
It would probably be cool, if you could inherit a opam-installer installPhase as well.
There was a problem hiding this comment.
What do you mean by “cool”? Should derivations be cool? I don’t see how this installPhase value could be shared among several derivations as it explicitly mentions the library name (twice). It is true however that the common and recurring parts could be factorized away in a library for building OCaml derivations.
There was a problem hiding this comment.
That is a good point, opam-installer does not necessarily need it, and buildOcaml should know the library name as the name attribute is the name without version and ocaml-prefix.
So I guess it could work?
There was a problem hiding this comment.
This seems possible. I will give it a try.
… name It can then be reused as-is in other derivations (e.g., uucd).
fmt is an OCaml library of Format pretty-printer combinators. Homepage: http://erratique.ch/software/fmt
|
Updated to take into account @sternenseemann’s suggestion: inheriting the |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)