Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: d22e0f0df015
Choose a base ref
...
head repository: jruby/jruby
compare: 0a56927cd17b
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 20, 2016

  1. Add Pathname#empty? 

    * Add `Pathname#empty?`
* Remove `empty?` implementation on `File` since `FileTest` will assign its implementation of `empty?` to `File` (see `RubyFileTest.FileTestFileMethods`)
* Add `FileTest.empty?`

The last two steps were down in this PR in order to base the implementation of `Pathname#empty?` on the MRI implementation.

See #4293
    @kcdragon
    kcdragon committed Nov 20, 2016
    Copy the full SHA
    e62be22 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. Use direct calls to RubyFileTest and RubyDir instead of `callMeth… 

    …od`. Fix `else` style problem.
    @kcdragon
    kcdragon committed Nov 21, 2016
    Copy the full SHA
    e6a5888 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2016

  1. Undoing direct calls to RubyFileTest and RubyDir

    @kcdragon
    kcdragon committed Nov 22, 2016
    Copy the full SHA
    45dc119 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4322 from kcdragon/md/feature/add-pathname-empty 

    Add `Pathname#empty?`
    @enebo
    enebo committed Nov 22, 2016
    Copy the full SHA
    0a56927 View commit details
    Browse the repository at this point in the history