Rename MetaCPAN::Role Script and code cleanup.

metacpan · Aug 20, 2014 · 845c2ab · 845c2ab
1 parent 25ef822
commit 845c2ab
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/lib/MetaCPAN/Document/Stargazer.pm b/lib/MetaCPAN/Document/Stargazer.pm
@@ -5,13 +5,13 @@ use warnings;
 
 use Moose;
 use ElasticSearchX::Model::Document;
-
 use DateTime;
 use MetaCPAN::Types qw(:all);
 
 has id => (
-    is => 'ro',
-    id => [qw(user module)],
+    is  => 'ro',
+    id  => [qw(user module)],
+    isa => 'NonEmptySimpleStr',
 );
 
 has [qw(author release user module)] => (

diff --git a/lib/MetaCPAN/Server/Controller/Stargazer.pm b/lib/MetaCPAN/Server/Controller/Stargazer.pm
@@ -13,7 +13,6 @@ with 'MetaCPAN::Server::Role::JSONP';
 sub find : Path('') : Args(2) {
     my ( $self, $c, $user, $module ) = @_;
     try {
-
         my $stargazer = $self->model($c)->raw->get(
             {
                 user   => $user,
@@ -23,7 +22,7 @@ sub find : Path('') : Args(2) {
         $c->stash( $stargazer->{_source} || $stargazer->{fields} );
     }
     catch {
-        $c->detach( '/not_found', [$@] );
+        $c->detach( '/not_found', [$_] );
     };
 }
 

diff --git a/lib/MetaCPAN/Server/Controller/User/Stargazer.pm b/lib/MetaCPAN/Server/Controller/User/Stargazer.pm
@@ -7,7 +7,7 @@ use Moose;
 
 BEGIN { extends 'Catalyst::Controller::REST' }
 
-with 'MetaCPAN::Server::Role::MapStarring';
+with 'MetaCPAN::Server::Role::Starring';
 
 sub auto : Private {
     my ( $self, $c ) = @_;

diff --git a/lib/MetaCPAN/Server/Role/MapStarring.pm → lib/MetaCPAN/Server/Role/Starring.pm b/lib/MetaCPAN/Server/Role/MapStarring.pm → lib/MetaCPAN/Server/Role/Starring.pm
@@ -1,4 +1,4 @@
-package MetaCPAN::Server::Role::MapStarring;
+package MetaCPAN::Server::Role::Starring;
 
 use strict;
 use warnings;
@@ -10,11 +10,10 @@ sub index_POST {
     my $req  = $c->req;
     my $star = $c->model('CPAN::Stargazer')->put(
         {
-            user    => $c->user->id,
             author  => $req->data->{author},
-            release => $req->data->{release},
             module  => $req->data->{module},
-            author  => $req->data->{author},
+            release => $req->data->{release},
+            user    => $c->user->id,
         },
         { refresh => 1 }
     );