Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby-openssl
base: 2678bab65a6a
Choose a base ref
...
head repository: jruby/jruby-openssl
compare: bf9420c5c607
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 26, 2016

  1. Don't print a warning for missing client certs 

    When you run Ruby with warnings enabled and your (HTTPS) server does not verify clients you don't expect to see a warning about clients not being verified. 

For example, WEBrick's default configuration does not verify client certificates (https://github.com/jruby/jruby/blob/b610805cd55ef5d56d8e431918753fc92fad5ef5/lib/ruby/stdlib/webrick/ssl.rb#L74), but when running an HTTP server in JRuby it prints "warning: javax.net.ssl.SSLPeerUnverifiedException: peer not authenticated" for every request. This does not happen in MRI.
    @iconara
    iconara committed Oct 26, 2016
    Configuration menu
    Copy the full SHA
    6a4ee35 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #110 from iconara/no-warnings-on-missing-client-cert 

    Don't print a warning for missing client certs
    @kares
    kares committed Oct 26, 2016
    Configuration menu
    Copy the full SHA
    bf9420c View commit details
    Browse the repository at this point in the history