Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs-24.5-mac-5.15: fixed package by adding build tools #20536

Merged
merged 1 commit into from Dec 13, 2016

Conversation

TikhonJelvis
Copy link
Contributor

Motivation for this change

Fixes the build which was missing automake and autoconf.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@TikhonJelvis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jwiegley, @pikajude and @ttuegel to be potential reviewers.

@periklis
Copy link
Contributor

Please correct the PR-Title, it's not emacs-25.5, it's emacs-24.5. Thx!

@TikhonJelvis TikhonJelvis changed the title emacs-25.5-mac-5.15: fixed package by adding build tools emacs-24.5-mac-5.15: fixed package by adding build tools Nov 21, 2016
@TikhonJelvis
Copy link
Contributor Author

@periklis Thanks! Updated the title.

I also looked at the Travis errors and didn't understand where they came from.

One of the builds failed on Linux by timing out—presumably this isn't a problem because this package is meant for MacOS only?

The build on OSX with XCode 7.3 failed because Emacs was missing X:

checking for libXaw... configure: error: No X toolkit could be found.
If you are sure you want Emacs compiled without an X toolkit, pass
  --with-x-toolkit=no
to configure.  Otherwise, install the development libraries for the toolkit
that you want to use (e.g. Gtk+) and re-run configure.
builder for ‘/nix/store/rkjxs75glqq3f3r3cbjqv95fmhys2lac-emacs-24.5-mac-5.15.drv’ failed with exit code 1

This looks like a something to do with how the build machine was configured—I don't understand why the build failed like this.

@matthewbauer
Copy link
Member

@TikhonJelvis Emacs mac port should use cocoa instead of x. See issue #20682.

@TikhonJelvis
Copy link
Contributor Author

Okay, if I'm understanding correctly, I'm running into the same bug as #20682? Is there anything I should do, or should I just wait for that problem to be resolved? I don't think I'm familiar enough with the package to try fixing that problem myself.

@matthewbauer matthewbauer mentioned this pull request Dec 13, 2016
7 tasks
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 13, 2016
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably explains the issues I was seeing with #20706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants