Support to_yaml in YAML.mapping generated classes #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxpowa Looks good, thank you! Do you want to add a spec too? |
|
AFAIK @maxpowa is currently working on specs and supporting converters etc. |
|
@RX14 is correct, I'm working on converters/emit_null etc - essentially to support what JSON supports. |
|
Added support for converters, |
maxpowa
force-pushed
the
mapping-to-yaml
branch
from
5697698
to
7dc80dc
Compare
firejox
pushed a commit
to firejox/crystal
that referenced
this pull request
Dec 12, 2016
* Support to_yaml in YAML.mapping generated classes * Support converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
to_yamlon classes generated throughYAML.mapping, prior to this patch you'd get an error as demonstrated here.