Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting to updated version of flake8. #2563

Merged
merged 1 commit into from Nov 20, 2016
Merged

Adjusting to updated version of flake8. #2563

merged 1 commit into from Nov 20, 2016

Conversation

felixfontein
Copy link
Contributor

A new version of flake8 contains a new (or updated?) rule (E305) which makes Nikola fail flake8. This PR should fix it.

@felixfontein
Copy link
Contributor Author

The baseline test is (not surprisingly) failing because:

  1. I had to change one of the source files in the example site as well;
  2. thumbnails have a different binary result than in the baseline.

Kwpolska
Kwpolska approved these changes Nov 20, 2016
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Those thumbnail issues are caused by Pillow upgrades.

@Kwpolska Kwpolska merged commit 100b043 into master Nov 20, 2016
@Kwpolska Kwpolska deleted the fixing-flake8-problems branch November 20, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska