Merge pull request #1815 from metacpan/oalders/more-changes-fixes

Cover more date formatting cases in Changes files.
metacpan · Nov 20, 2016 · d7001aa · d7001aa
2 parents f86565f + 2a5170c
commit d7001aa
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/lib/MetaCPAN/Web/Model/API/Changes/Parser.pm b/lib/MetaCPAN/Web/Model/API/Changes/Parser.pm
@@ -49,20 +49,30 @@ sub parse {
     # handle localtime-like timestamps
     # May Tue 03 17:25:00 2005
     # /changes/distribution/Catalyst-View-PSP
+    #
+    # Thu Nov 19 09:25:53 2009
+    # /changes/distribution/GO-TermFinder
+    #
+    # Sun Jan  29 2012
+    # /changes/distribution/Scalar-Constant
     # XXX haarg is going to rip this out and replace it with something better.
                 elsif ( $note
                     =~ s{^(\D{3})\s+(\D{3})\s+(\d{1,2})\s+([\d:]+)?\D*(\d{4})}{}
                     )
                 {
-                    if ($4) {
+                    my $month = $months{$1} || $months{$2};
+                    if ( $month && $3 && $4 && $5 ) {
 
                         # unfortunately ignores TZ data
-                        $date = sprintf( '%d-%02d-%02dT%sZ',
-                            $5, $months{$1}, $3, $4 );
+                        $date = sprintf( '%d-%02d-%02dT%sZ', $5, $month, $3,
+                            $4 );
+                    }
+                    elsif ( $month && $2 && $4 ) {
+                        $date = sprintf( '%d-%02d-%02d', $4, $month, $2 );
                     }
                     else {
-                        $date
-                            = sprintf( '%d-%02d-%02d', $4, $months{$1}, $2 );
+                        $note = join q{ }, grep {defined} $1, $2, $3, $4, $5,
+                            $note;
                     }
                 }