There are no bashisms, use /bin/sh #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I worry that I will introduce a bashism accidently without noticing.... |
|
Add a test that runs it with |
|
Could you add one? |
|
Added. |
mithro
reviewed
Nov 22, 2016
| echo "Not a member of the video group"; exit 1; \ | ||
| fi | ||
| @for HELP in hdmi2usb-*-helper.sh; do \ |
There was a problem hiding this comment.
This should probably be in a test: target... check: is more for "checking things are installed correctly and up to date".
There was a problem hiding this comment.
That makes more sense. In many Makefiles, check is a synonym for test.
|
Can you make travis run the check too? |
|
Done. Although travis doesn't get that far, as we know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.