Item14204: Failed to return parse errors

Check for JSON version was masking errors detected by the json parser.
foswiki · Nov 1, 2016 · 8d393a3 · 8d393a3
1 parent 4b0fbfd
commit 8d393a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/JsonRpcContrib/lib/Foswiki/Request/JSON.pm b/JsonRpcContrib/lib/Foswiki/Request/JSON.pm
@@ -199,6 +199,8 @@ sub _establishJSON {
 
     $this->initFromString($data);
 
+    return if ( $this->{_jsonerror} );
+
     # some basic checks if this is a proper json-rpc 2.0 request
 
     # must have a version tag

diff --git a/JsonRpcContrib/test/unit/JsonRpcContrib/JsonrpcTests.pm b/JsonRpcContrib/test/unit/JsonRpcContrib/JsonrpcTests.pm
@@ -225,7 +225,7 @@ sub test_redirectto_Anchor {
     Foswiki::Contrib::JsonRpcContrib::registerMethod( __PACKAGE__, 'trial',
         \&json_handler );
 
-    my $query = Unit::Request->new(
+    my $query = Unit::Request::JSON->new(
         {
             action     => ['jsonrpc'],
             redirectto => "$this->{test_web}/$this->{test_topic}#MyAnch",