Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Add default encodings to encoding manager #4258

Merged
merged 15 commits into from Nov 3, 2016

Conversation

nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented Nov 1, 2016

No description provided.

@nirvdrum nirvdrum added this to the truffle-dev milestone Nov 1, 2016
@nirvdrum nirvdrum changed the title Add default encodings to encoding manager [Truffle] Add default encodings to encoding manager Nov 1, 2016
@nirvdrum nirvdrum force-pushed the add-default-encodings-to-encoding-manager branch from bbfd8db to 5cb84b2 Compare November 1, 2016 13:02
…ngs in EncodingManager.

A side effect of this change is we're no longer updating the JRuby runtime's default_external and default_internal values. As a result, we can't use methods from the JRuby runtime that rely on those values being up-to-date. Since RubyString#inspect is one such method, we have to move that back out to Ruby (String#inspect). This code has ping-ponged a few times between a Ruby and Java implementation. It appears whatever issue forced the move back to Java (i.e., RubyString#inspect) has been addressed.
…codings.

Also, started moving non-standard Encoding methods out to Truffle::Encoding.
These methods became a lot simpler once we started tracking default_external and default_internal encodings in the EncodingManager.
This reverts a large part of 1f88220 and 3beeeb8. As it turns out, the iterators provided by jcodings are a good enough interface and other usability improvements have been made, obviating the need for this visitor pattern.
We load all encodings eagerly and account for dummy encodings during bootstrap.
@nirvdrum nirvdrum force-pushed the add-default-encodings-to-encoding-manager branch from 5cb84b2 to 8f80540 Compare November 1, 2016 13:48
The file on Travis refers to snapshot servers that are no longer online and may cause build problems.
@chrisseaton chrisseaton merged commit 2dcbc66 into truffle-head Nov 3, 2016
@chrisseaton chrisseaton deleted the add-default-encodings-to-encoding-manager branch November 3, 2016 01:00
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants