-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Add default encodings to encoding manager #4258
Merged
chrisseaton
merged 15 commits into
truffle-head
from
add-default-encodings-to-encoding-manager
Nov 3, 2016
Merged
[Truffle] Add default encodings to encoding manager #4258
chrisseaton
merged 15 commits into
truffle-head
from
add-default-encodings-to-encoding-manager
Nov 3, 2016
+494
−353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n they shouldn't be.
bbfd8db
to
5cb84b2
Compare
…ngs in EncodingManager. A side effect of this change is we're no longer updating the JRuby runtime's default_external and default_internal values. As a result, we can't use methods from the JRuby runtime that rely on those values being up-to-date. Since RubyString#inspect is one such method, we have to move that back out to Ruby (String#inspect). This code has ping-ponged a few times between a Ruby and Java implementation. It appears whatever issue forced the move back to Java (i.e., RubyString#inspect) has been addressed.
…codings. Also, started moving non-standard Encoding methods out to Truffle::Encoding.
These methods became a lot simpler once we started tracking default_external and default_internal encodings in the EncodingManager.
…e during initialization.
We load all encodings eagerly and account for dummy encodings during bootstrap.
5cb84b2
to
8f80540
Compare
The file on Travis refers to snapshot servers that are no longer online and may cause build problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.