Catch LinkageError during DynamicScope generation. #4285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple threads are generating the same DynamicScope class, both threads may try to generate the same class at the same time. When the second thread hits defineClass, it throws a LinkageError becuase the class has already been defined. With this change we catch this exception and call loadClass to get the class that the previous thread created.
|
Maybe we should just lock around the class generation bit? |
|
I will incorporate your patch but with some double-checked locking around class generation, so we can simply avoid the exception when there's parallel generation going on. |
headius
added a commit
that referenced
this pull request
Nov 14, 2016
This is an enhancement to #4285 to avoid the exception altogether. Any remaining exceptions that bubble out are intended to do so, so we can see them and get reports and fix them. This modification should effectively prevent double-loading (which caused the LinkageError) but have reduced overhead.
|
Great find, thanks! |
|
Thanks for the fast response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple threads are generating the same DynamicScope class, both
threads may try to generate the same class at the same time. When the second
thread hits defineClass, it throws a LinkageError because the class has already
been defined.
With this change we catch this exception and call loadClass to get the class that
the previous thread created.