Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to handle more than 64 channels in moninj #605

Merged
merged 2 commits into from
Nov 4, 2016

Conversation

dnadlinger
Copy link
Collaborator

See GitHub #601 and the individual commit messages for details.

I've made this PR against the release-2 branch since it fixes a nasty surprise and is minimally invasive, but I'd be happy to open a PR against the Rust runtime in master as well.

Previously, you could irreversibly set the override since
the gateware part would accept commands for the higher channels,
but of coure not report back the results.

See GitHub m-labs#601.

Signed-off-by: David Nadlinger <code@klickverbot.at>
Since the status words are only 8 bytes wide, left-shifting
by more than that is undefined behaviour (although it seems like
we got lucky and Clang dind't decide to optimise the whole
implementation away).

See GitHub m-labs#601.

Signed-off-by: David Nadlinger <code@klickverbot.at>
@dnadlinger dnadlinger changed the title Don't try and handle more than 64 channels in moninj Don't try to handle more than 64 channels in moninj Nov 4, 2016
@sbourdeauducq sbourdeauducq merged commit d5974b3 into m-labs:release-2 Nov 4, 2016
@dnadlinger dnadlinger deleted the release-2-moninj branch November 4, 2016 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants