-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.mezzanine: fixes #19989 #20152
Conversation
cc @lsix |
Packages shouldn't depend on a specific version by directly referring to the attribute. What I mean is, its not good to have
|
Perfectly, it works: it has the same behaviour for |
even so, I am not so fond of having this. What you easily get now is that you include this package, and then another package that also depends on django, and suddenly you have two versions of django in your closure...oops! Instead, the user should override the package set and select the correct Django. |
@FRidh, I've updated MR. Is it ready to be merged? |
While I am not fond of this solution, it is okay. But, before I merge, is there any reason not to update mezzanine to the latest available version? |
Because, unless some other Nixpkgs package needs it, we do not keep older versions. |
Yes, it makes sense. But I need to update |
do you need all packages, including this mezzanine, at the latest version, or not? If not I suggest you use pypi2nix |
No, I personaly don't need the latest version of |
ohh, ok. Since the mezzanine version we have is so old and because it is not worked you can add |
Seems fair to me to mark it as broken until someone proceed with the updates. |
Motivation for this change
mezzanine
depends onDjango-1.6
that does not supportpython>3.3
. But it also depends onfilebrowser_safe
that depens onself.django
that is actually aDjango-1.10
. I've explicitly overrideddjango
for dependentfilebrowser_safe
to get a correct installation error.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)Tests: