Skip to content

WIP: pythonPackages.pyjwt: 1.4.0 -> 1.4.2 #19935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: pythonPackages.pyjwt: 1.4.0 -> 1.4.2 #19935

wants to merge 1 commit into from
+18 −3

Conversation

igsha
Copy link
Contributor

@igsha igsha commented Oct 27, 2016

Motivation for this change

1.4.0 version has wrong version of installed package:

[22:22] igor@nixos-pc nixpkgs (pyjwt *) $ ls /nix/store/iic4b8zv78rplx4gs5vmadsadxaf1j9n-python3.5-pyjwt-1.4.0/lib/python3.5/site-packages/
jwt  PyJWT-0.3.2.dist-info

1.4.2 version fixes this:

[22:20] igor@nixos-pc nixpkgs (pyjwt *) $ ls /nix/store/p5qs5qy1n6vsr953svzzbakw3z8w30dp-python3.5-pyjwt-1.4.2/lib/python3.5/site-packages/
jwt  PyJWT-1.4.2.dist-info
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Full list of dependent:

lrwxrwxrwx 1 igor users 54 Oct 27 22:16 result -> /nix/store/1299ncg4sbhjknip34bqyr4w1vx5dnw2-nixops-1.4
lrwxrwxrwx 1 igor users 64 Oct 27 22:16 result-2 -> /nix/store/fq2569s0i3zgqq1ba8p9bnlsb6nd9jx7-python2.7-adal-0.1.0
lrwxrwxrwx 1 igor users 65 Oct 27 22:16 result-3 -> /nix/store/iic4b8zv78rplx4gs5vmadsadxaf1j9n-python3.5-pyjwt-1.4.0
lrwxrwxrwx 1 igor users 65 Oct 27 22:16 result-4 -> /nix/store/va98gqj0sdlp2qw2q37qijigrms95gjc-python2.7-pyjwt-1.4.0
lrwxrwxrwx 1 igor users 64 Oct 27 22:16 result-5 -> /nix/store/3rrrxxf893fj4lxiw9h5fgwf833kh6df-python3.5-adal-0.1.0
lrwxrwxrwx 1 igor users 65 Oct 27 22:16 result-6 -> /nix/store/4bdp2lk5fss6q3h8wg9gs7y86g7p4qfc-python2.7-pyjwt-1.4.2
lrwxrwxrwx 1 igor users 65 Oct 27 22:16 result-7 -> /nix/store/p5qs5qy1n6vsr953svzzbakw3z8w30dp-python3.5-pyjwt-1.4.2

Test binaries:

[22:16] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result/bin/nixops list-generations
error: could not find specified deployment in state file ‘/home/igor/.nixops/deployments.nixops’
[22:17] igor@nixos-pc nixpkgs (pyjwt *) ✗ (1) $ /run/user/1000/nox-review-byezun16/result-3/bin/jwt --key=secret foo=bar message=hello exp=+1000
b'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJtZXNzYWdlIjoiaGVsbG8iLCJleHAiOjE0Nzc1OTY5MDMsImZvbyI6ImJhciJ9.Zz3Z2HSDzH5dWt52HGfJF5pGlWiuzBmdQGF-DRe89l4'
[22:18] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result-3/bin/jwt --key=secret 'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJtZXNzYWdlIjoiaGVsbG8iLCJleHAiOjE0Nzc1OTY5MDMsImZvbyI6ImJhciJ9.Zz3Z2HSDzH5dWt52HGfJF5pGlWiuzBmdQGF-DRe89l4'
{"exp": 1477596903, "foo": "bar", "message": "hello"}
[22:18] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result-6/bin/jwt --key=secret foo=bar message=hello oa=me exp=+1000
eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJtZXNzYWdlIjoiaGVsbG8iLCJmb28iOiJiYXIiLCJleHAiOjE0Nzc1OTY5NDIsIm9hIjoibWUifQ.74KH2oIXov_jv-UdjbNDkb9yFVx9YArH0YE9y3Nb_c4
[22:19] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result-6/bin/jwt --key=secret eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJtZXNzYWdlIjoiaGVsbG8iLCJmb28iOiJiYXIiLCJleHAiOjE0Nzc1OTY5NDIsIm9hIjoibWUifQ.74KH2oIXov_jv-UdjbNDkb9yFVx9YArH0YE9y3Nb_c4
{"message": "hello", "foo": "bar", "oa": "me", "exp": 1477596942}
[22:19] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result-7/bin/jwt --key=secret message=hello oa=me exp=+1000
b'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE0Nzc1OTcwMDEsIm1lc3NhZ2UiOiJoZWxsbyIsIm9hIjoibWUifQ.dMVJJlf16fnvMTBq4mUyBDYcnx8C_l2xnyXBLXBobcs'
[22:20] igor@nixos-pc nixpkgs (pyjwt *) $ /run/user/1000/nox-review-byezun16/result-7/bin/jwt --key=secret 'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE0Nzc1OTcwMDEsIm1lc3NhZ2UiOiJoZWxsbyIsIm9hIjoibWUifQ.dMVJJlf16fnvMTBq4mUyBDYcnx8C_l2xnyXBLXBobcs'
{"message": "hello", "oa": "me", "exp": 1477597001}

Old 1.4.0 package is preserved for oathlib package because it can be compiled only with 1.4.0.

[22:29] igor@nixos-pc nixpkgs (pyjwt *) $ nix-shell -I nixpkgs=~/nixpkgs -p pythonPackages.oauthlib
[22:30] igor@nixos-pc nixpkgs (pyjwt *) [nix-shell] % python
Python 2.7.12 (default, Jun 25 2016, 21:49:32) 
[GCC 5.4.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import oauthlib
>>> help(oauthlib)

Sorry, something went wrong.

@igsha
pythonPackages.pyjwt: 1.4.0 -> 1.4.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nomadium Miguel Landaeta
GPG key ID: AFB8E0FC9231CC6D
Expired
Verified
Learn about vigilant mode
ac42b41
@FRidh
Copy link
Member

FRidh commented Oct 28, 2016

Old 1.4.0 package is preserved for oathlib package because it can be compiled only with 1.4.0.

Maybe its possible to update oauthlib?

@igsha
Copy link
Contributor Author

igsha commented Oct 30, 2016

Yes, it is possible. I'm stuck on #19989, #19988, and #19987. I believe that they can be easily fixed.

@igsha igsha changed the title pythonPackages.pyjwt: 1.4.0 -> 1.4.2 WIP: pythonPackages.pyjwt: 1.4.0 -> 1.4.2 Oct 30, 2016
@igsha igsha mentioned this pull request Nov 6, 2016
Closed
7 tasks
@FRidh
Copy link
Member

FRidh commented Dec 1, 2016

see e39584c

@FRidh FRidh closed this Dec 1, 2016
@igsha igsha deleted the pyjwt branch November 18, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igsha @FRidh