Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portaudio: 19-20140130 -> 19-20161030 #20592

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

TravisWhitaker
Copy link
Contributor

Motivation for this change

Update.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@TravisWhitaker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bluescreen303, @lovek323 and @bjornfor to be potential reviewers.

@TravisWhitaker
Copy link
Contributor Author

Note that two reverse dependencies already fail to build, ultrastardx (#20568) and octaveFull (#20589) and so can't be tested for compatibility.

@TravisWhitaker
Copy link
Contributor Author

@vcunat also a potential reviewer.

@joachifm joachifm merged commit 44122e2 into NixOS:master Nov 24, 2016
@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

The source hash wasn't changed!

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

Meaning you most likely haven't tested building from the new source at all.

vcunat added a commit that referenced this pull request Nov 25, 2016
This reverts commit 44122e2, reversing
changes made to d66db99.

The hash wasn't changed, meaning this won't work and the build is most
likely untested.
@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

Reverted for now.

@TravisWhitaker
Copy link
Contributor Author

Oh dear, I did neglect to update the source hash. However, in my branch nix-build ./default.nix -A portaudio fetches and builds portaudio-19-20161030 without complaining about a hash mismatch.

Can anyone else confirm this?

@TravisWhitaker
Copy link
Contributor Author

@vcunat the build is tested and reverse dependencies pass tests, with the exception of ultrastardx and octaveFull whose derivations are broken.

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

It fetches the old source, as we employ hash-addressing to find cached sources on tarballs.nixos.org

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

Meaning it builds (and tests) the old version.

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

For prefetching sources I recommend

$ nix-prefetch-url -A portaudio.src
downloading ‘http://www.portaudio.com/archives/pa_stable_v190600_20161030.tgz’... [831/1417 KiB, 708.3 KiB/s]
path is ‘/nix/store/6lvv07wxgwi6641jkqbb11s20qdk3b7f-pa_stable_v190600_20161030.tgz’
04qmin6nj144b8qb9kkd9a52xfvm0qdgm8bg8jbl7s3frmyiv8pm

@TravisWhitaker
Copy link
Contributor Author

Ah, that explains it then. My apologies.

For which derivations does tarballs.nixos.org cache the source? Typically if I forget to update the hash an error is generated.

@vcunat thanks for the catch, and thanks for the nix-prefetch-url tip!

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

It's not fully automatic (see e.g. #11782), but all default fetchurl invocations check the location.

@vcunat
Copy link
Member

vcunat commented Nov 25, 2016

The mistake is relatively common; unfortunately I don't know a good way to prevent it from happening (meaning especially people who don't know about it).

@joachifm
Copy link
Contributor

Oops. Don't know how I missed that, I did look. Oh, well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants