Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 98362a323baf
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a11e75b1cfc7
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 29, 2016

  1. [Truffle] Fix the SlowSpecsTagger.

    * MSpec might not be fully require'd when this is loaded.
    eregon committed Oct 29, 2016
    Copy the full SHA
    2c9d64b View commit details
  2. [Truffle] Tag slow specs.

    eregon committed Oct 29, 2016
    Copy the full SHA
    a11e75b View commit details
Showing with 15 additions and 1 deletion.
  1. +12 −0 spec/truffle/tags/core/io/popen_tags.txt
  2. +3 −1 spec/truffle/truffle.mspec
12 changes: 12 additions & 0 deletions spec/truffle/tags/core/io/popen_tags.txt
Original file line number Diff line number Diff line change
@@ -22,3 +22,15 @@ fails:IO.popen with a leading Array argument accepts '[env, command, arg1, arg2,
fails:IO.popen raises IOError when writing a read-only pipe
fails:IO.popen reads and writes a read/write pipe
slow:IO.popen sees an infinitely looping subprocess exit when read pipe is closed
slow:IO.popen returns an open IO
slow:IO.popen reads a read-only pipe
slow:IO.popen writes to a write-only pipe
slow:IO.popen raises IOError when reading a write-only pipe
slow:IO.popen waits for the child to finish
slow:IO.popen does not throw an exception if child exited and has been waited for
slow:IO.popen returns an instance of a subclass when called on a subclass
slow:IO.popen coerces mode argument with #to_str
slow:IO.popen has the given external encoding
slow:IO.popen has the given internal encoding
slow:IO.popen sets the internal encoding to nil if it's the same as the external encoding
slow:IO.popen with a block yields an open IO to the block
4 changes: 3 additions & 1 deletion spec/truffle/truffle.mspec
Original file line number Diff line number Diff line change
@@ -151,8 +151,10 @@ class MSpecScript
set :files, get(:language) + get(:core) + get(:library) + get(:truffle)
end

is_child_process = respond_to?(:ruby_exe)
is_child_process = ENV.key? "MSPEC_RUNNER"
if i = ARGV.index('slow') and ARGV[i-1] == '--excl-tag' and is_child_process
require 'mspec'

class SlowSpecsTagger
def initialize
MSpec.register :exception, self