Add mean iteration time to Benchmark.ips #3483
Merged
+65
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up the code to be more readable by using variable assignment instead of yielding a tuple.
RX14
changed the title
|
Not sure what happened to the 32bit build... |
|
Looks nice and useful, thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mean time per iteration to the output of
Benchmark.ips. I find this metric quite useful in addition to iterations per second because it's an easier metric to compare to values like network roundtrip times and disk seeks.Also cleans up
Benchmark::IPS::Entry#human_mean, and fixes output with iteration times greater than 10 seconds (log10(mean) < -1)