thanks, would be better to give it a go on JRuby 9.1.5.0 instead of 9.0.5.0 (that or a reduced test-case)

9.1.5.0 has the same issue:

class Post
  protected
  def metadata
  end
end
puts Post.new.respond_to?(:metadata).inspect


$ ruby -v
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]
$ ruby respond.rb
false


$ ruby -v
jruby 9.1.5.0 (2.3.1) 2016-09-07 036ce39 Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]
$ ruby respond.rb
true

cc @headius

cc @enebo

@kirs this is fixed in 9.1.6.0. Can you confirm that?

I confirm that ❤️
I'll update Rails to use 9.1.6.0.

I think the issue can be closed.

Ooops, I was wrong:

$ jruby -v
jruby 9.1.6.0 (2.3.1) 2016-11-09 0150a76 Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]

# post.rb
class Post
  protected
  def metadata
  end
end
puts Post.new.respond_to?(:metadata).inspect

$ jruby post.rb
true

@kirs interestingly the bug we fixed in 9.1.6.0 was the exact opposite problem that we were not seeing true when we should have. Thanks for checking.

Maybe you fixed it for private methods, but not for protected?

On Wed, Nov 16, 2016 at 9:30 AM, Thomas E Enebo notifications@github.com
wrote:

@kirs https://github.com/kirs interestingly the bug we fixed in 9.1.6.0
was the exact opposite problem that we were not seeing true when we should
have. Thanks for checking.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4253 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAf3q_se33BTum75qDiOLIq4pC36cB2Gks5q-xOcgaJpZM4KiH7E
.

@kirs the fix was for protected methods and involved us not checking beneath a particular point due to the use of prepended modules. We were getting false back and not true due to us not searching past the prepended module. I read this issue backwards.

Thanks for the background! In my case above there're no prepended modules involved.

@enebo this is still an issue on master. Do you have any suggestion how I can fix it? It currently blocks us on the Rails side.
Thanks!

@kirs I will see if I can get any insight into this. One weird thing is respond_to? even in a method of the same type returns true while mri will return false. So post will really respond to being sent metadata but the respond_to? method will still say false?

@enebo not exactly. As a result, respond_to? => true on JRuby leads to NoMethodError being triggered:

class Post
  protected
  def metadata
  end
end
post = Post.new
if post.respond_to?(:metadata)
  post.metadata
else
  puts "no metadata available"
end

$ bin/jruby respond.rb
NoMethodError: protected method `metadata' called for #<Post:0x4923ab24>
  <main> at respond.rb:8

While on MRI that works as expected:

$ chruby ruby-2.3.3
$ ruby respond.rb
no metadata available

@kirs I think I have this fixed locally. Running tests now. If appears for dispatch we only care about private visibility but for respond_to? we care about both private and protected. It is a lack of symmetry.

Awesome. I'm looking forward for updates from you.

@kirs kick the tires on this one. I did actually find some tagged out specs on this and I feel fairly confident about the fix but nonetheless this is pretty low-level language mojo :)

Thanks! ❤️
Now it works as expected.