Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: e15f837dfd7c^
Choose a base ref
...
head repository: jruby/jruby
compare: f172304fcdb4
Choose a head ref
  • 8 commits
  • 15 files changed
  • 1 contributor

Commits on Oct 28, 2016

  1. Configuration menu
    Copy the full SHA
    e15f837 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2016

  1. Configuration menu
    Copy the full SHA
    cae3e78 View commit details
    Browse the repository at this point in the history
  2. [Truffle] Keep track of default_external and default_internal encondi…

    …ngs in EncodingManager.
    
    A side effect of this change is we're no longer updating the JRuby runtime's default_external and default_internal values. As a result, we can't use methods from the JRuby runtime that rely on those values being up-to-date. Since RubyString#inspect is one such method, we have to move that back out to Ruby (String#inspect). This code has ping-ponged a few times between a Ruby and Java implementation. It appears whatever issue forced the move back to Java (i.e., RubyString#inspect) has been addressed.
    nirvdrum committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    f7aae66 View commit details
    Browse the repository at this point in the history
  3. [Truffle] Simplified setting default_external and default_internal en…

    …codings.
    
    Also, started moving non-standard Encoding methods out to Truffle::Encoding.
    nirvdrum committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    c4e535a View commit details
    Browse the repository at this point in the history
  4. [Truffle] Removed unnecessary boundaries.

    These methods became a lot simpler once we started tracking default_external and default_internal encodings in the EncodingManager.
    nirvdrum committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    fb95da0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    01b1bdb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    128f7dc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f172304 View commit details
    Browse the repository at this point in the history